go-e2e-battery-clean-18-18

Answer

Root cause. scripts/e2e-smoke.sh executes bin/helios directly. If Go source is newer than the binary (an edit after the last make build-bin-all), the battery silently runs an old artifact: legs fail for the wrong reason (behavior drift), or worse, pass when the new code is broken. The battery's result is then meaningless, and the failure mode is invisible until someone notices the mtimes.

Fix — two complementary defences (both are required: the Makefile dependency covers the documented entry point; the script-level gate covers direct/CI/pre-commit invocations and gives an actionable error instead of a misleading battery run).

1. New scripts/check-bin-fresh.sh — the freshness gate (fails with the exact fix command when any tracked *.go is strictly newer than bin/helios, or when the binary is missing; git-scoped so tarball-export noise and scratch files are ignored; resolves symlinked bins):

#!/usr/bin/env bash
set -euo pipefail

REPO_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)"
BIN="$REPO_ROOT/bin/helios"

if [ ! -e "$BIN" ]; then
  echo "check-bin-fresh: FAIL — $BIN does not exist." >&2
  echo "  fix: run 'make build-bin-all'" >&2
  exit 1
fi
REAL_BIN="$(readlink -f "$BIN")"            # symlinked bin/

if git -C "$REPO_ROOT" rev-parse --git-dir >/dev/null 2>&1; then
  mapfile -d '' SRC_FILES < <(git -C "$REPO_ROOT" ls-files -z -- '*.go')
else
  while IFS= read -r -d '' f; do SRC_FILES+=("$f"); done \
    < <(find "$REPO_ROOT" -type f -name '*.go' -print0)
fi

for f in "${SRC_FILES[@]}"; do
  if [ -n "$(find "$f" -newer "$REAL_BIN" -print -quit 2>/dev/null)" ]; then
    echo "check-bin-fresh: FAIL — Go source newer than binary: $f" >&2
    echo "  fix: run 'make build-bin-all'" >&2
    exit 1
  fi
done
echo "check-bin-fresh: OK — bin/helios is newer than all ${#SRC_FILES[@]} tracked Go sources."

find -newer uses strict mtime >, so a same-second rebuild is correctly considered fresh.

2. scripts/e2e-smoke.sh — gate is leg #1, abort is fail-fast with exit 2 (battery body unchanged: migrate 25/25, openapi unauth/authed, register/dup/empty, login/bad-creds/empty, Bearer incident create/list + garbage-token, PRAGMA 43/25, log scan, clean shutdown — 18 legs):

# --- Freshness gate (fail fast, actionable) ---
if ! "$REPO_ROOT/scripts/check-bin-fresh.sh"; then
  echo "E2E-001 ABORT: bin/helios is stale — run 'make build-bin-all' first." >&2
  exit 2
fi
ok "freshness gate (check-bin-fresh)"

3. Makefile — the entry point can never be stale:

BIN := bin/helios
.PHONY: build-bin-all check-bin-fresh e2e-smoke clean

build-bin-all:
    @mkdir -p bin
    cd cmd/helios && go build -o ../../$(BIN) .

check-bin-fresh:
    scripts/check-bin-fresh.sh

e2e-smoke: build-bin-all          # rebuild first ⇒ staleness impossible here
    scripts/e2e-smoke.sh

Net effect: 18/18 PASS on fresh sqlite; a stale bin/helios now yields check-bin-fresh: FAIL … fix: run 'make build-bin-all' and aborts the battery (exit 2) instead of silently running the wrong build.