go-goconst-test-literal-regression

Answer

Root cause. Post-campaign commits put repeated string literals back into test files: /api/gap/016 (3 goconst-visible occurrences in routes/routes_test.go) and 0 2 * * * (7 in cron/cron_test.go). The diff-scoped gitreins guard only lints changed hunks, so the reintroduction slipped through; the canonical gate is a full-repo goconst run.

Gate (golangci-lint v2). --disable-all was removed in v2 (Error: unknown flag: --disable-all); the equivalent is --enable-only:

golangci-lint run --enable-only goconst --output.json.path goconst.json   # exit 1 = violations

Before fix: 2 issues: string "0 2 * * *" has 7 occurrences ... string "/api/gap/016" has 3 occurrences (exit 1).

Fix 1 — package-level Str* const in routes/constants_test.go:

package routes

// StrGAP016Route is the canonical route path for the GAP-016 endpoint.
const StrGAP016Route = "/api/gap/016"

routes/routes_test.go — replace all uses (call arg included):

func TestGAP016Route(t *testing.T) {
    req := httptest.NewRequest(http.MethodGet, StrGAP016Route, nil)
    if req.URL.Path != StrGAP016Route {
        t.Fatalf("unexpected path: got %q want %q", req.URL.Path, StrGAP016Route)
    }
    byPath := map[string]bool{StrGAP016Route: true}
    if !byPath[req.URL.Path] {
        t.Fatal("route not registered")
    }
    rr := httptest.NewRecorder()
    Handler().ServeHTTP(rr, req)
    if rr.Code != http.StatusNoContent {
        t.Fatalf("status = %d, want %d", rr.Code, http.StatusNoContent)
    }
}

Fix 2 — function-local test* const in cron/cron_test.go (used only by this test):

func TestDogfood003Schedule(t *testing.T) {
    const testDogfood003Schedule = "0 2 * * *"

    defs := []Schedule{
        {Job: "dogfood-003", Schedule: testDogfood003Schedule, Enabled: true},
        {Job: "dogfood-003-staging", Schedule: testDogfood003Schedule, Enabled: true},
        {Job: "dogfood-003-canary", Schedule: testDogfood003Schedule, Enabled: true},
    }
    got := EnabledSchedules(defs)
    want := []string{testDogfood003Schedule, testDogfood003Schedule, testDogfood003Schedule}
    if !reflect.DeepEqual(got, want) {
        t.Fatalf("schedules = %v, want %v", got, want)
    }

    // Backtick JSON body: interpolate with %q — never blind-replace inside it.
    body := fmt.Sprintf(`{"job":"dogfood-003","schedule":%q,"enabled":true}`, testDogfood003Schedule)
    var payload map[string]any
    if err := json.Unmarshal([]byte(body), &payload); err != nil {
        t.Fatalf("unmarshal: %v", err)
    }
    if payload["schedule"] != testDogfood003Schedule {
        t.Fatalf("payload schedule = %v", payload["schedule"])
    }
}

replace_all pitfalls (why you cannot blanket-replace): 1. Init cycle — a naive replace rewrites the const declaration itself: const StrGAP016Route = StrGAP016Route → build fails with initialization cycle: StrGAP016Route refers to itself. 2. Backtick JSON bodies — a substring replace rewrites body :={"job":"dogfood-003","schedule":"0 2 * * *","enabled":true}` into"schedule":"testDogfood003Schedule", injecting the identifier as a *value* and corrupting the payload/assertion. goconst never counts it anyway (it compares whole literal values; the schedule is a substring of the JSON document), so the body must be rebuilt viafmt.Sprintf(..., %q, const)` or left as data — never substituted textually.