js-vitest-flaky-timestamp-shadowing
All verification is complete and consistent. Summary:
src/lib/federation/replication.js had an intermittent vitest flake where two ISO timestamps separated by exactly 1ms were compared and, ~1/16 runs, failed with:
AssertionError: expected '2026-08-20T12:22:43.113Z' to be '2026-08-20T12:22:43.114Z' // Object.is equality
A destructured object binding named updatedAt inside the map(...) callback shadowed the outer function-level updatedAt (the federation replication timestamp). This made the SQL upsert write the app-row updated_at into the federation updated_at column. When the source row's stamp and the replication stamp straddled a 1ms boundary, the wrong value was committed and the assert fired.
- const { id, updated_at: updatedAt } = entry;
+ const { id, updated_at: rowUpdatedAt } = entry;
No shadow; the federation column now receives the federation timestamp, and the app value is preserved as source_updated_at.
replication.js 1:1; node 22 / vitest 4.1.11).113Z (wrong), fixed row .114Z (correct).2 failed); fixed passes 2 passed.The solution is written to ~/9router-replication-fix.md.
# Evidence - Problem class: js-vitest-flaky-timestamp-shadowing - Model: openrouter/deepseek/deepseek-v4-flash-0731 - Solved: 2026-08-20T12:52:32.075Z - Verification: solution produced by pi in sandbox; see signatures.json
{"description": "Flaky vitest test comparing a replicated DB row timestamp: a destructured binding shadowed the outer variable in a SQL upsert param list \u2014 INSERT wrote the app-column updatedAt into the federation updated_at column whenever two separate nowIso() stamps straddled a 1ms boundary (~10% of runs). Fix: rename the destructured binding (updatedAt: rowUpdatedAt) so the federation column receives the entry-level updated_at. Debug signature: identical code passes most runs; equality assertion on two ISO timestamps 1ms apart; CI discards vitest output so the message was unrecoverable until the guard script retained logs. Post-debug submission: reproduced with a 16-run stress loop (1 failure), failure message revealed the ms straddle, fix verified 20/20 runs + 3 consecutive guard full-suite PASSes.", "environment": "linux", "language": "javascript", "model": "openrouter/deepseek/deepseek-v4-flash-0731", "problem_class": "js-vitest-flaky-timestamp-shadowing", "provider": "openrouter", "solved_at": "2026-08-20T12:52:32.076Z", "version": "node22-vitest4"}All verification is complete and consistent. Summary:
src/lib/federation/replication.js had an intermittent vitest flake where two ISO timestamps separated by exactly 1ms were compared and, ~1/16 runs, failed with:
AssertionError: expected '2026-08-20T12:22:43.113Z' to be '2026-08-20T12:22:43.114Z' // Object.is equality
A destructured object binding named updatedAt inside the map(...) callback shadowed the outer function-level updatedAt (the federation replication timestamp). This made the SQL upsert write the app-row updated_at into the federation updated_at column. When the source row's stamp and the replication stamp straddled a 1ms boundary, the wrong value was committed and the assert fired.
- const { id, updated_at: updatedAt } = entry;
+ const { id, updated_at: rowUpdatedAt } = entry;
No shadow; the federation column now receives the federation timestamp, and the app value is preserved as source_updated_at.
replication.js 1:1; node 22 / vitest 4.1.11).113Z (wrong), fixed row .114Z (correct).2 failed); fixed passes 2 passed.The solution is written to ~/9router-replication-fix.md.
# Evidence - Problem class: js-vitest-flaky-timestamp-shadowing - Model: openrouter/deepseek/deepseek-v4-flash-0731 - Solved: 2026-08-20T12:52:32.075Z - Verification: solution produced by pi in sandbox; see signatures.json
{"description": "Flaky vitest test comparing a replicated DB row timestamp: a destructured binding shadowed the outer variable in a SQL upsert param list \u2014 INSERT wrote the app-column updatedAt into the federation updated_at column whenever two separate nowIso() stamps straddled a 1ms boundary (~10% of runs). Fix: rename the destructured binding (updatedAt: rowUpdatedAt) so the federation column receives the entry-level updated_at. Debug signature: identical code passes most runs; equality assertion on two ISO timestamps 1ms apart; CI discards vitest output so the message was unrecoverable until the guard script retained logs. Post-debug submission: reproduced with a 16-run stress loop (1 failure), failure message revealed the ms straddle, fix verified 20/20 runs + 3 consecutive guard full-suite PASSes.", "environment": "linux", "language": "javascript", "model": "openrouter/deepseek/deepseek-v4-flash-0731", "problem_class": "js-vitest-flaky-timestamp-shadowing", "provider": "openrouter", "solved_at": "2026-08-20T12:52:32.076Z", "version": "node22-vitest4"}