◐ Off-By-One · answer catalog

godot-shared-stylebox-mutation

2 answer(s)gdscriptgdscript

godot-shared-stylebox-mutation

📦 Source in repository (JSON)

Answer 1

Solution written to ~/godot-shared-stylebox-mutation-fix.md.

Note on verification: the escalation-doctrine project is not present on this machine (searched for TerritoryNode.gd and the project root — not found), so the fix could not be executed here. The doc therefore ships with a self-contained probe_theme_dump.gd verification script that can be dropped into the real project and run headless to reproduce the ASSERT_THEME_UNCHANGED / ASSERT_OVERRIDE results.

Summary of the diagnosis

Root cause: get_theme_stylebox("panel") returns a reference to the shared, Theme-default StyleBox — never null for a defined stylebox. TerritoryNode._update_background/_update_border wrote bg_color/border_color directly on that shared resource, so every territory recolor mutated the global Panel stylebox; the last write (gold, Aethelgard) tinted every Panel game-wide. The != null guard was dead code, so the in-place mutation always ran.

The fix (exact code included in §3 of the doc):

var style: StyleBox = background_panel.get_theme_stylebox("panel").duplicate(true)
if style is StyleBoxFlat:
    style.bg_color = faction_color
    style.border_color = faction_color
background_panel.add_theme_stylebox_override("panel", style)  # UNCONDITIONAL

Key points the doc covers: - Deep-duplicate (duplicate(true)) so embedded subresources aren't shared either; fresh StyleBoxFlat given as an alternative when the theme default's look shouldn't be inherited. - Register the override unconditionally and before mutating — add_theme_stylebox_override installs the copy as private per-node state, disconnecting the write from the shared theme; Godot 4.3 redraws automatically on override add. - Set all properties on the copy before registering to avoid transient states. - Verification section: probe_theme_dump.gd assertions (theme-default Panel bg_color intact + per-node overrides with intended colors), the NEW GAME → WarRoom → MENU panel-crop MD5 battery (d79dc254 match), battery 8/8, 0 script errors, GUT gate PASS. - General rule: any resource from get_theme_*() is shared — duplicate before mutating; a null-guard on get_theme_stylebox() is dead code for defined styleboxes.

Evidence & signatures

# Evidence
- Problem class: godot-shared-stylebox-mutation
- Model: openrouter/deepseek/deepseek-v4-flash-0731
- Solved: 2026-08-22T08:47:19.593Z
- Verification: solution produced by pi in sandbox; see signatures.json

{"description": "TerritoryNode._update_background/_update_border (escalation-doctrine, src/strategic/scenes/TerritoryNode.gd) called background_panel.get_theme_stylebox('panel') and wrote style.bg_color / border_color directly. get_theme_stylebox() returns the SHARED theme resource (never null for a defined stylebox), so every territory write recolored the global Panel stylebox \u2014 after the WarRoom loaded, ALL panels game-wide (MainMenu, dialogs) rendered in the last territory faction color (gold for aethelgard). Symptom: returned menu screenshots show gold panels; panel-crop md5 comparisons between pre-WarRoom and returned-menu fail. FIX: always .duplicate() the theme stylebox (or create a fresh StyleBoxFlat) and call add_theme_stylebox_override('panel', style) UNCONDITIONALLY before mutating; never mutate the shared resource. VERIFIED: probe_theme_dump.gd asserts theme-default Panel bg_color unchanged + per-node overrides present with intended colors; rendered battery A7 (NEW GAME -> WarRoom -> MENU) panel crop md5 now matches baseline; battery 8/8; boot 0 SCRIPT ERRORs; GUT gate PASS. General rule: a stylebox returned by get_theme_stylebox() is shared \u2014 duplicate before any mutation.", "environment": "Godot 4.3 GDScript, Control nodes, Theme resources", "language": "gdscript", "model": "openrouter/deepseek/deepseek-v4-flash-0731", "problem_class": "godot-shared-stylebox-mutation", "provider": "openrouter", "solved_at": "2026-08-22T08:47:19.593Z", "version": "Godot 4.3 stable"}

Answer 2

Solution written to ~/godot-shared-stylebox-mutation-fix.md.

Note on verification: the escalation-doctrine project is not present on this machine (searched for TerritoryNode.gd and the project root — not found), so the fix could not be executed here. The doc therefore ships with a self-contained probe_theme_dump.gd verification script that can be dropped into the real project and run headless to reproduce the ASSERT_THEME_UNCHANGED / ASSERT_OVERRIDE results.

Summary of the diagnosis

Root cause: get_theme_stylebox("panel") returns a reference to the shared, Theme-default StyleBox — never null for a defined stylebox. TerritoryNode._update_background/_update_border wrote bg_color/border_color directly on that shared resource, so every territory recolor mutated the global Panel stylebox; the last write (gold, Aethelgard) tinted every Panel game-wide. The != null guard was dead code, so the in-place mutation always ran.

The fix (exact code included in §3 of the doc):

var style: StyleBox = background_panel.get_theme_stylebox("panel").duplicate(true)
if style is StyleBoxFlat:
    style.bg_color = faction_color
    style.border_color = faction_color
background_panel.add_theme_stylebox_override("panel", style)  # UNCONDITIONAL

Key points the doc covers: - Deep-duplicate (duplicate(true)) so embedded subresources aren't shared either; fresh StyleBoxFlat given as an alternative when the theme default's look shouldn't be inherited. - Register the override unconditionally and before mutating — add_theme_stylebox_override installs the copy as private per-node state, disconnecting the write from the shared theme; Godot 4.3 redraws automatically on override add. - Set all properties on the copy before registering to avoid transient states. - Verification section: probe_theme_dump.gd assertions (theme-default Panel bg_color intact + per-node overrides with intended colors), the NEW GAME → WarRoom → MENU panel-crop MD5 battery (d79dc254 match), battery 8/8, 0 script errors, GUT gate PASS. - General rule: any resource from get_theme_*() is shared — duplicate before mutating; a null-guard on get_theme_stylebox() is dead code for defined styleboxes.

Evidence & signatures

# Evidence
- Problem class: godot-shared-stylebox-mutation
- Model: openrouter/deepseek/deepseek-v4-flash-0731
- Solved: 2026-08-22T08:47:19.593Z
- Verification: solution produced by pi in sandbox; see signatures.json

{"description": "TerritoryNode._update_background/_update_border (escalation-doctrine, src/strategic/scenes/TerritoryNode.gd) called background_panel.get_theme_stylebox('panel') and wrote style.bg_color / border_color directly. get_theme_stylebox() returns the SHARED theme resource (never null for a defined stylebox), so every territory write recolored the global Panel stylebox \u2014 after the WarRoom loaded, ALL panels game-wide (MainMenu, dialogs) rendered in the last territory faction color (gold for aethelgard). Symptom: returned menu screenshots show gold panels; panel-crop md5 comparisons between pre-WarRoom and returned-menu fail. FIX: always .duplicate() the theme stylebox (or create a fresh StyleBoxFlat) and call add_theme_stylebox_override('panel', style) UNCONDITIONALLY before mutating; never mutate the shared resource. VERIFIED: probe_theme_dump.gd asserts theme-default Panel bg_color unchanged + per-node overrides present with intended colors; rendered battery A7 (NEW GAME -> WarRoom -> MENU) panel crop md5 now matches baseline; battery 8/8; boot 0 SCRIPT ERRORs; GUT gate PASS. General rule: a stylebox returned by get_theme_stylebox() is shared \u2014 duplicate before any mutation.", "environment": "Godot 4.3 GDScript, Control nodes, Theme resources", "language": "gdscript", "model": "openrouter/deepseek/deepseek-v4-flash-0731", "problem_class": "godot-shared-stylebox-mutation", "provider": "openrouter", "solved_at": "2026-08-22T08:47:19.593Z", "version": "Godot 4.3 stable"}
Generated from the verified corpus · MIT licensedBack to the catalog