golangci-unparam-unused-param
Done. All artifacts are in place and verified.
/workspace/solution.md — self-contained writeup with title, root-cause analysis, the exact 2-line fix, and verification. Highlights:
ba117ce added executeForEach(ctx, node, env, specPolicy) where both extra params are dead: env just re-aliases the Env snapshot the Runner already owns internally, and specPolicy is never read because each template iteration runs its own RunPipeline and the failure policy is hardcoded to skip.golangci-lint run ./... gate battery surfaced it.src/runner/runner.go):
diff
-func (r *Runner) executeForEach(ctx context.Context, node Node, env Env, specPolicy SpecPolicy) error {
+func (r *Runner) executeForEach(ctx context.Context, node Node) error {
```diff``Env/SpecPolicytypes stay; only the method parameters and its single call site (executeNode`) change./workspace/repro/ — a faithful <project> module reproduction (src/runner/runner.go) used to prove the diagnosis end-to-end.
Reconstructed the exact diagnostic class on the buggy code:
src/runner/runner.go:107:65: `(*Runner).executeForEach` - `env` is unused (unparam)
then proved the one-param-at-a-time behavior with three lint passes:
| Pass | State | Result |
|---|---|---|
| 1 | buggy | env is unused (unparam) — exit 1 |
| 2 | removed env only |
specPolicy is unused (unparam) — exit 1 |
| 3 | removed both | 0 issues — exit 0 |
Final gate battery on the fixed fixture: go build OK · go vet OK · go test -race OK (1.011s) · golangci-lint run ./... exit 0 · gofmt clean.
Lesson encoded in the writeup: guard lint is scoped and can miss unparam regressions on worker commits; the full-module gate battery is the source of truth; and unparam requires a lint re-run after each parameter removal.
# Evidence - Problem class: golangci-unparam-unused-param - Model: openrouter/deepseek/deepseek-v4-flash-0731 - Solved: 2026-08-22T22:08:08.331Z - Verification: solution produced by pi in sandbox; see signatures.json
{"description": "Worker commit ba117ce introduced func (r *Runner) executeForEach(ctx, node, env, specPolicy) where BOTH env and specPolicy were never used in the body (template iterations run their own RunPipeline; Runner holds env internally; error policy hardcoded to skip). The gitreins Tier-1 guard lint reported PASS on the worker commit, but a standalone `golangci-lint run ./...` in the next tick's gate battery flagged unparam for env, and after removing env, flagged specPolicy next (unparam reports one param at a time). Fix: drop both unused params from the signature and the single call site (executeNode) \u2014 2-line change, build/vet/race tests all green, lint 0 issues, judge PASS. Lesson: guard lint can miss unparam regressions on worker commits; run standalone golangci-lint in tick batteries; unparam iterates one unused param at a time so re-run after each removal.", "environment": "<project> Go 1.23 runner (src/runner), golangci-lint unparam linter, gitreins Tier-1 guard pre-commit hook, scheduler foreman tick gate battery", "language": "go", "model": "openrouter/deepseek/deepseek-v4-flash-0731", "problem_class": "golangci-unparam-unused-param", "provider": "openrouter", "solved_at": "2026-08-22T22:08:08.331Z", "version": "master ae43329"}Done. All artifacts are in place and verified.
/workspace/solution.md — self-contained writeup with title, root-cause analysis, the exact 2-line fix, and verification. Highlights:
ba117ce added executeForEach(ctx, node, env, specPolicy) where both extra params are dead: env just re-aliases the Env snapshot the Runner already owns internally, and specPolicy is never read because each template iteration runs its own RunPipeline and the failure policy is hardcoded to skip.golangci-lint run ./... gate battery surfaced it.src/runner/runner.go):
diff
-func (r *Runner) executeForEach(ctx context.Context, node Node, env Env, specPolicy SpecPolicy) error {
+func (r *Runner) executeForEach(ctx context.Context, node Node) error {
```diff``Env/SpecPolicytypes stay; only the method parameters and its single call site (executeNode`) change./workspace/repro/ — a faithful <project> module reproduction (src/runner/runner.go) used to prove the diagnosis end-to-end.
Reconstructed the exact diagnostic class on the buggy code:
src/runner/runner.go:107:65: `(*Runner).executeForEach` - `env` is unused (unparam)
then proved the one-param-at-a-time behavior with three lint passes:
| Pass | State | Result |
|---|---|---|
| 1 | buggy | env is unused (unparam) — exit 1 |
| 2 | removed env only |
specPolicy is unused (unparam) — exit 1 |
| 3 | removed both | 0 issues — exit 0 |
Final gate battery on the fixed fixture: go build OK · go vet OK · go test -race OK (1.011s) · golangci-lint run ./... exit 0 · gofmt clean.
Lesson encoded in the writeup: guard lint is scoped and can miss unparam regressions on worker commits; the full-module gate battery is the source of truth; and unparam requires a lint re-run after each parameter removal.
# Evidence - Problem class: golangci-unparam-unused-param - Model: openrouter/deepseek/deepseek-v4-flash-0731 - Solved: 2026-08-22T22:08:08.331Z - Verification: solution produced by pi in sandbox; see signatures.json
{"description": "Worker commit ba117ce introduced func (r *Runner) executeForEach(ctx, node, env, specPolicy) where BOTH env and specPolicy were never used in the body (template iterations run their own RunPipeline; Runner holds env internally; error policy hardcoded to skip). The gitreins Tier-1 guard lint reported PASS on the worker commit, but a standalone `golangci-lint run ./...` in the next tick's gate battery flagged unparam for env, and after removing env, flagged specPolicy next (unparam reports one param at a time). Fix: drop both unused params from the signature and the single call site (executeNode) \u2014 2-line change, build/vet/race tests all green, lint 0 issues, judge PASS. Lesson: guard lint can miss unparam regressions on worker commits; run standalone golangci-lint in tick batteries; unparam iterates one unused param at a time so re-run after each removal.", "environment": "<project> Go 1.23 runner (src/runner), golangci-lint unparam linter, gitreins Tier-1 guard pre-commit hook, scheduler foreman tick gate battery", "language": "go", "model": "openrouter/deepseek/deepseek-v4-flash-0731", "problem_class": "golangci-unparam-unused-param", "provider": "openrouter", "solved_at": "2026-08-22T22:08:08.331Z", "version": "master ae43329"}