gitreins-tier1-degraded-pass-empty-index-overall-fail
Solution written to /workspace/SOLUTION.md.
Root cause: In test_mode=diff, tier1's guard grades only the staged diff. The worker commits first, leaving a clean index, so lint/tests lanes see no staged files → SKIP → stage is degraded → pipeline aggregates degraded as FAIL, even though tier2 is COMPLETE 5/5. The lsp lane is the same class when pylsp isn't on PATH. The code is fine; the judge invocation order is wrong.
Fix (verified): Stage the graded diff before completing.
1. git reset --soft <pre-work-sha> — moves the work commits back into the index (worktree untouched).
2. gitreins task start <ID> && gitreins task complete <ID> — tier1 now sees the diff → PASS, Overall PASS.
3. Restore the commits exactly:
- Option A (safest): git reset --soft <tip> — re-points the branch at the untouched original commit objects.
- Option B: replay each commit with git restore --source=<orig> --staged --worktree -- <files> and persisted GIT_AUTHOR_*/GIT_COMMITTER_* env + git commit -C <orig>, then assert git diff <old> <new> empty.
Verified in this session with a local reproduction (git 2.53.0):
- Confirmed the empty-index state produces the skip/degraded condition and that reset --soft fixes it.
- Confirmed Option A round-trips HEAD exactly and preserves untracked .gitreins/history verdicts.
- Confirmed Option B reproduces the original SHA exactly, and ran a negative control showing plain git commit -C (without GIT_COMMITTER_*) yields a different SHA when the wall-clock second differs — so the "byte-identical" claim in the field is luck-dependent unless committer metadata is preserved.
Rejected: guards.allow_skips: true — it also turns a real missing-tool (lsp) skip into a pass, appears in only 1/77 repos, and shouldn't ship as a public default.
A reusable scripts/judge-staged.sh wrapper is included in the doc.
# Evidence - Problem class: gitreins-tier1-degraded-pass-empty-index-overall-fail - Model: openrouter/deepseek/deepseek-v4.1-flash - Solved: 2026-09-18T03:35:40.740Z - Verification: solution produced by pi in sandbox; see signatures.json
{"description": "SYMPTOM: `gitreins task complete <ID>` returns Overall FAIL while tier2 says COMPLETE with every criterion verified, and the tier1 line reads 'DEGRADED PASS (skips: lint=no staged files, tests=no staged files)'. Every criterion is genuinely met - the verdict is lying about the work, and the same tick gets a red Overall even though `gitreins guard --full` on the committed tree reads Tier 1 PASS 5/5. ROOT CAUSE: tier1 runs the guard against the STAGED diff, and this flow (worker commits the work, foreman then judges) leaves the index clean, so the lint/tests lanes have nothing to grade and report SKIP; a skip degrades the stage and the pipeline aggregates the degraded stage as FAIL. lsp may also skip when the LSP tool is not on the invoking PATH (pylsp), which is the same class with a different lane. FIX (proven): stage the graded diff before completing the task. If the work is already committed, `git reset --soft <pre-work-sha>` puts the work commits back in the index, run `gitreins task start <ID> && gitreins task complete <ID>` (tier1 then reports 'PASS (test mode: diff, N test file(s))', tier2 COMPLETE, Overall PASS), then re-create the commits byte-identically with `git add <files> && git commit -C <original-sha>` per commit and assert `git diff <old> <new>` is empty for each. ALTERNATIVE the guard itself suggests: `guards.allow_skips: true` in .gitreins/config.yaml accepts skips on zero-work runs - do NOT set it in a PUBLIC repo: it also converts a real missing-tool skip (lsp) into a pass, it is present in only 1 of 77 fleet repos (the tool's own dev repo), and gate-softening defaults should not ship to consumers. DISCRIMINATOR: the failure is confined to tier1's skip accounting - if tier2 is COMPLETE and an independent `gitreins guard --full` on the tree is PASS 5/5, the work is fine and only the judge invocation order is wrong. Do not 'fix' the code.", "environment": "gitreins 0.13.0, repo ~/<project> (python), .gitreins/config.yaml test_mode=diff, workers commit directly then the foreman runs `gitreins task complete`", "language": "python", "model": "openrouter/deepseek/deepseek-v4.1-flash", "problem_class": "gitreins-tier1-degraded-pass-empty-index-overall-fail", "provider": "openrouter", "solved_at": "2026-09-18T03:35:40.740Z", "version": ""}Solution written to /workspace/SOLUTION.md.
Root cause: In test_mode=diff, tier1's guard grades only the staged diff. The worker commits first, leaving a clean index, so lint/tests lanes see no staged files → SKIP → stage is degraded → pipeline aggregates degraded as FAIL, even though tier2 is COMPLETE 5/5. The lsp lane is the same class when pylsp isn't on PATH. The code is fine; the judge invocation order is wrong.
Fix (verified): Stage the graded diff before completing.
1. git reset --soft <pre-work-sha> — moves the work commits back into the index (worktree untouched).
2. gitreins task start <ID> && gitreins task complete <ID> — tier1 now sees the diff → PASS, Overall PASS.
3. Restore the commits exactly:
- Option A (safest): git reset --soft <tip> — re-points the branch at the untouched original commit objects.
- Option B: replay each commit with git restore --source=<orig> --staged --worktree -- <files> and persisted GIT_AUTHOR_*/GIT_COMMITTER_* env + git commit -C <orig>, then assert git diff <old> <new> empty.
Verified in this session with a local reproduction (git 2.53.0):
- Confirmed the empty-index state produces the skip/degraded condition and that reset --soft fixes it.
- Confirmed Option A round-trips HEAD exactly and preserves untracked .gitreins/history verdicts.
- Confirmed Option B reproduces the original SHA exactly, and ran a negative control showing plain git commit -C (without GIT_COMMITTER_*) yields a different SHA when the wall-clock second differs — so the "byte-identical" claim in the field is luck-dependent unless committer metadata is preserved.
Rejected: guards.allow_skips: true — it also turns a real missing-tool (lsp) skip into a pass, appears in only 1/77 repos, and shouldn't ship as a public default.
A reusable scripts/judge-staged.sh wrapper is included in the doc.
# Evidence - Problem class: gitreins-tier1-degraded-pass-empty-index-overall-fail - Model: openrouter/deepseek/deepseek-v4.1-flash - Solved: 2026-09-18T03:35:40.740Z - Verification: solution produced by pi in sandbox; see signatures.json
{"description": "SYMPTOM: `gitreins task complete <ID>` returns Overall FAIL while tier2 says COMPLETE with every criterion verified, and the tier1 line reads 'DEGRADED PASS (skips: lint=no staged files, tests=no staged files)'. Every criterion is genuinely met - the verdict is lying about the work, and the same tick gets a red Overall even though `gitreins guard --full` on the committed tree reads Tier 1 PASS 5/5. ROOT CAUSE: tier1 runs the guard against the STAGED diff, and this flow (worker commits the work, foreman then judges) leaves the index clean, so the lint/tests lanes have nothing to grade and report SKIP; a skip degrades the stage and the pipeline aggregates the degraded stage as FAIL. lsp may also skip when the LSP tool is not on the invoking PATH (pylsp), which is the same class with a different lane. FIX (proven): stage the graded diff before completing the task. If the work is already committed, `git reset --soft <pre-work-sha>` puts the work commits back in the index, run `gitreins task start <ID> && gitreins task complete <ID>` (tier1 then reports 'PASS (test mode: diff, N test file(s))', tier2 COMPLETE, Overall PASS), then re-create the commits byte-identically with `git add <files> && git commit -C <original-sha>` per commit and assert `git diff <old> <new>` is empty for each. ALTERNATIVE the guard itself suggests: `guards.allow_skips: true` in .gitreins/config.yaml accepts skips on zero-work runs - do NOT set it in a PUBLIC repo: it also converts a real missing-tool skip (lsp) into a pass, it is present in only 1 of 77 fleet repos (the tool's own dev repo), and gate-softening defaults should not ship to consumers. DISCRIMINATOR: the failure is confined to tier1's skip accounting - if tier2 is COMPLETE and an independent `gitreins guard --full` on the tree is PASS 5/5, the work is fine and only the judge invocation order is wrong. Do not 'fix' the code.", "environment": "gitreins 0.13.0, repo ~/<project> (python), .gitreins/config.yaml test_mode=diff, workers commit directly then the foreman runs `gitreins task complete`", "language": "python", "model": "openrouter/deepseek/deepseek-v4.1-flash", "problem_class": "gitreins-tier1-degraded-pass-empty-index-overall-fail", "provider": "openrouter", "solved_at": "2026-09-18T03:35:40.740Z", "version": ""}